Codecov Report

Merging #668 (45227c9) into master (d350c1b) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
+ Coverage   94.03%   94.25%   +0.22%     
==========================================
  Files          31       31              
  Lines        6636     7207     +571     
  Branches      726      855     +129     
==========================================
+ Hits         6240     6793     +553     
- Misses        258      279      +21     
+ Partials      138      135       -3     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d350c1b...45227c9. Read the comment docs.

@adam-urbanczyk and @marcus7070 I think this is ready for review. Please pay special attention to the tolerance and angularTolerance parameter descriptions. I'm not sure that I grasp the nuances of each of those well enough to describe them properly.

The last two commits were me (incompetently) trying to make git diff display the SVGs as "new file", instead of printing out a complete text diff for a file we'll never edit by hand.

@adam-urbanczyk The tolerance default for exporters.export() is 0.1, but the default for tolerance in exportStl() is 1e-3. It seems like export() is always going to override the default for exportStl(), which seems like it might not be intended. I wanted to bring it up to confirm.

Looks good, but you might want to state that angularTolerance is a maximum tangent error between the mesh and the original shape. I need to look into the tolerance value, that does not block the PR, right?

https://dev.opencascade.org/doc/overview/html/occt_user_guides__mesh.html

is a maximum tangent error between the mesh and the original shape.

Is that in addition to, or instead of, what's in the doc now?

@jmwright after reading the docs again I conclude that I might've misinterpreted what is stated (and drawn) there. +1 for merging as-is.

Thanks @jmwright!

Thanks indeed, it'll be very helpful for the users!